Handle duplicate X-WR-TIMEZONE values - #43
Merged
niccokunzmann merged 3 commits intoJun 11, 2026
Conversation
Member
|
Thank you for your PR! It would be nice if you could also edit the contributing file. |
niccokunzmann
requested changes
Jun 4, 2026
| DTSTART:20240101T120000Z | ||
| DTEND:20240101T130000Z | ||
| END:VEVENT | ||
| END:VCALENDAR |
Member
There was a problem hiding this comment.
Hi, the tests have a calendars directory. Please put all calendars in there.
legalverb
force-pushed
the
fix-duplicate-x-wr-timezone
branch
from
June 5, 2026 02:23
443cfba to
851e705
Compare
Contributor
Author
|
Thanks for the review. I moved the duplicate X-WR-TIMEZONE test calendars into test/calendars and rebased the branch on current main, so the PR is mergeable again. Local verification:
|
niccokunzmann
approved these changes
Jun 11, 2026
niccokunzmann
left a comment
niccokunzmann
left a comment
Member
There was a problem hiding this comment.
Thanks! Perfect! Merging....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25.
Summary
X-WR-TIMEZONEvalues before resolving them withzoneinfo.X-WR-TIMEZONEentries agree.Behavior
The issue did not include the original ICS file, so this keeps the behavior conservative:
Tests
. .venv/bin/activate && pytest test/test_convert_examples.py -q. .venv/bin/activate && pytest -qsh test/test_code_quality.shgit diff --checkNote: CONTRIBUTING.md asks for a changelog entry except for trivial changes, but I could not find a changelog/news file in this repository to update.